Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SearchBundle] Remove Sherlock elastic provider docs #2956

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[SearchBundle] Remove Sherlock elastic provider docs #2956

merged 1 commit into from
Oct 6, 2021

Conversation

tarjei
Copy link
Contributor

@tarjei tarjei commented Oct 3, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets comma separated list of tickets fixed by the PR

ProfessorKuma
ProfessorKuma suggested changes Oct 3, 2021
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.
  • your PR title should look like [SomeBundle] Fixed some code

@ProfessorKuma ProfessorKuma added this to the 5.9.0 milestone Oct 3, 2021
@acrobat acrobat changed the title AFAIK Sherlock is not used anymore? [SearchBundle] Remove Sherlock elastic provider docs Oct 6, 2021
@acrobat acrobat merged commit f4c1562 into Kunstmaan:master Oct 6, 2021
@acrobat
Copy link
Member

acrobat commented Oct 6, 2021

Thanks @tarjei!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma requested changes

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
Type: Bugfix Type: Deprecation
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tarjei @acrobat @ProfessorKuma